Skip to content

Comments

refactor: address code review feedback for embedding performance impr…#92

Merged
Classic298 merged 1 commit intoembedding-perffrom
claude/review-embedding-api-012FRbP65G7KaK6LBa3fKfK4
Nov 20, 2025
Merged

refactor: address code review feedback for embedding performance impr…#92
Classic298 merged 1 commit intoembedding-perffrom
claude/review-embedding-api-012FRbP65G7KaK6LBa3fKfK4

Conversation

@Classic298
Copy link
Owner

No description provided.

…ovements

- Remove duplicate async embedding functions (generate_openai_batch_embeddings_async,
  generate_azure_openai_batch_embeddings_async, generate_ollama_batch_embeddings_async,
  generate_multiple_async)
- Replace manual header construction with include_user_info_headers() helper
- Rename json_data to form_data for consistency with codebase conventions
- Rename 'elem' to 'item' in response parsing for better readability
- Remove unnecessary retry loop from Azure OpenAI async function
- Restore lambda wrappers with user parameter in embedding_function calls
  (routers/retrieval.py and utils/middleware.py) to ensure user context is preserved
- Revert reranking function signature to match dev branch
  (lambda query, documents instead of lambda sentences)
- Restore separate condition checks with warning logs in query_doc_with_hybrid_search

These changes maintain the core parallel embedding performance improvements while
addressing maintainer feedback for code quality and consistency.
@Classic298 Classic298 merged commit 6e13c66 into embedding-perf Nov 20, 2025
Classic298 added a commit that referenced this pull request Nov 24, 2025
…#19296)

* Update utils.py (#77)

Co-authored-by: Claude <[email protected]>

* refactor: address code review feedback for embedding performance improvements (#92)

Co-authored-by: Claude <[email protected]>

* fix: prevent sentence transformers from blocking async event loop (#95)

Co-authored-by: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants