refactor: address code review feedback for embedding performance impr…#92
Merged
Classic298 merged 1 commit intoembedding-perffrom Nov 20, 2025
Conversation
…ovements - Remove duplicate async embedding functions (generate_openai_batch_embeddings_async, generate_azure_openai_batch_embeddings_async, generate_ollama_batch_embeddings_async, generate_multiple_async) - Replace manual header construction with include_user_info_headers() helper - Rename json_data to form_data for consistency with codebase conventions - Rename 'elem' to 'item' in response parsing for better readability - Remove unnecessary retry loop from Azure OpenAI async function - Restore lambda wrappers with user parameter in embedding_function calls (routers/retrieval.py and utils/middleware.py) to ensure user context is preserved - Revert reranking function signature to match dev branch (lambda query, documents instead of lambda sentences) - Restore separate condition checks with warning logs in query_doc_with_hybrid_search These changes maintain the core parallel embedding performance improvements while addressing maintainer feedback for code quality and consistency.
Classic298
added a commit
that referenced
this pull request
Nov 24, 2025
…#19296) * Update utils.py (#77) Co-authored-by: Claude <[email protected]> * refactor: address code review feedback for embedding performance improvements (#92) Co-authored-by: Claude <[email protected]> * fix: prevent sentence transformers from blocking async event loop (#95) Co-authored-by: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.