Skip to content

Comments

Merge pull request open-webui#19030 from open-webui/dev#119

Merged
Classic298 merged 10 commits intorem-old-log-commandsfrom
claude/analyze-logger-config-ei03r
Dec 19, 2025
Merged

Merge pull request open-webui#19030 from open-webui/dev#119
Classic298 merged 10 commits intorem-old-log-commandsfrom
claude/analyze-logger-config-ei03r

Conversation

@Classic298
Copy link
Owner

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • [Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)]

Added

  • [List any new features, functionalities, or additions]

Changed

  • [List any changes, updates, refactorings, or optimizations]

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • [List any fixes, corrections, or bug fixes]

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

  • [Insert any additional context, notes, or explanations for the changes]
    • [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

tjbck and others added 10 commits November 23, 2025 22:10
Analysis reveals that individual module log levels (RAG_LOG_LEVEL,
AUDIO_LOG_LEVEL, etc.) have limited effectiveness due to force=True
in root logger configuration.

Key findings:
- Individual levels can only suppress logs (make less verbose)
- Cannot increase verbosity beyond GLOBAL_LOG_LEVEL
- Affects 94 files across codebase
- Root handler level acts as hard minimum

Includes three solution options with recommendations.
This commit simplifies the logging configuration by removing the
individual module-specific log levels that had limited effectiveness.

Changes:
- Removed SRC_LOG_LEVELS dictionary and configuration from env.py
- Removed log.setLevel(SRC_LOG_LEVELS[...]) from 99 files
- Removed SRC_LOG_LEVELS imports from all modules
- Updated LOGGING_ANALYSIS.md to reflect implementation

The individual log levels could only suppress logs (make less verbose)
but could not enable more verbose logging due to the root handler
being configured with force=True at the GLOBAL_LOG_LEVEL.

Files modified: 100
- backend/open_webui/env.py (removed configuration)
- backend/open_webui/**/*.py (removed usage, 99 files)
- LOGGING_ANALYSIS.md (documented implementation)

Users should now use only GLOBAL_LOG_LEVEL environment variable
for all logging configuration.
@Classic298 Classic298 merged commit be05d3a into rem-old-log-commands Dec 19, 2025
Classic298 added a commit that referenced this pull request Dec 20, 2025
…bui#20045)

* Update openai.py

* Update env.py

* Merge pull request open-webui#19030 from open-webui/dev (#119)

Co-authored-by: Tim Baek <[email protected]>
Co-authored-by: Claude <[email protected]>

---------

Co-authored-by: Tim Baek <[email protected]>
Co-authored-by: Claude <[email protected]>
@Classic298 Classic298 deleted the claude/analyze-logger-config-ei03r branch December 21, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants