Skip to content

Comments

Claude/find active user count 1ct t1#116

Merged
Classic298 merged 10 commits intopublic-user-countfrom
claude/find-active-user-count-1ctT1
Dec 18, 2025
Merged

Claude/find active user count 1ct t1#116
Classic298 merged 10 commits intopublic-user-countfrom
claude/find-active-user-count-1ctT1

Conversation

@Classic298
Copy link
Owner

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • [Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)]

Added

  • [List any new features, functionalities, or additions]

Changed

  • [List any changes, updates, refactorings, or optimizations]

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • [List any fixes, corrections, or bug fixes]

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

  • [Insert any additional context, notes, or explanations for the changes]
    • [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

tjbck and others added 10 commits November 23, 2025 22:10
Introduces SHOW_ACTIVE_USERS_COUNT_ADMIN_ONLY environment variable that,
when enabled, restricts the active user count display to admin users only.

This change provides:
- Privacy: Non-admin users cannot see how many users are active
- Performance: Reduces backend load by preventing API requests from
  non-admin users when the feature is enabled
- Scalability: Significantly reduces /api/usage endpoint calls in
  deployments with hundreds of concurrent users

Changes:
- Backend: Add SHOW_ACTIVE_USERS_COUNT_ADMIN_ONLY env variable in env.py
- Backend: Expose config setting via /api/config endpoint
- Frontend: Check user role and config before displaying active user count
- Frontend: Prevent API calls to /api/usage when user is not authorized

Default behavior: Feature is disabled (false) to maintain backward
compatibility. All users can see active user count unless explicitly
restricted by setting SHOW_ACTIVE_USERS_COUNT_ADMIN_ONLY=true.

Resolves open-webui#13026
Rename environment variable from SHOW_ACTIVE_USERS_COUNT_ADMIN_ONLY to
ENABLE_ACTIVE_USERS_COUNT_ADMIN_ONLY to follow the established naming
convention used throughout the codebase where feature flags start with
ENABLE_.

Changes:
- Backend: Renamed env variable in env.py
- Backend: Updated import and API response key in main.py
- Frontend: Updated config key reference in UserMenu.svelte

The functionality remains the same - when set to true, only admin users
can see the active user count display.
Rename environment variable to ENABLE_PUBLIC_ACTIVE_USERS_COUNT and
reverse the logic for better clarity and consistency with codebase
naming conventions.

Changes:
- Variable: ENABLE_PUBLIC_ACTIVE_USERS_COUNT (default: "True")
- When True (default): Everyone can see active user count (current behavior)
- When False: Only admins can see active user count
- Updated frontend logic to match reversed semantics

This naming better follows the ENABLE_* pattern used throughout the
codebase and makes the purpose more intuitive: "enable public visibility"
is clearer than "enable admin-only restriction".
Add proper authorization check in the /api/usage endpoint to enforce
access control when ENABLE_PUBLIC_ACTIVE_USERS_COUNT is disabled.

Previously, the restriction was only enforced on the frontend, allowing
users to bypass it by directly calling the API endpoint. Now:
- When ENABLE_PUBLIC_ACTIVE_USERS_COUNT=false, only admins can access
- Returns 403 Forbidden for non-admin users when restricted
- Properly re-raises HTTPException to preserve status codes

This completes the security implementation and ensures the performance
benefits are fully realized by preventing unauthorized API access at
the backend level.
@Classic298 Classic298 merged commit 470b7c7 into public-user-count Dec 18, 2025
@Classic298 Classic298 deleted the claude/find-active-user-count-1ctT1 branch December 18, 2025 13:07
Classic298 added a commit that referenced this pull request Dec 20, 2025
…pen-webui#20027)

* Merge pull request open-webui#19030 from open-webui/dev (#115)

Co-authored-by: Tim Baek <[email protected]>
Co-authored-by: Claude <[email protected]>
Resolves open-webui#13026

* Claude/find active user count 1ct t1 (#116)

Co-authored-by: Tim Baek <[email protected]>
Co-authored-by: Claude <[email protected]>
Resolves open-webui#13026

* Claude/find active user count 1ct t1 (#117)

Co-authored-by: Tim Baek <[email protected]>
Co-authored-by: Claude <[email protected]>
Resolves open-webui#13026

---------

Co-authored-by: Tim Baek <[email protected]>
Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants