Claude/find active user count 1ct t1#116
Merged
Classic298 merged 10 commits intopublic-user-countfrom Dec 18, 2025
Merged
Conversation
chore: format
Introduces SHOW_ACTIVE_USERS_COUNT_ADMIN_ONLY environment variable that, when enabled, restricts the active user count display to admin users only. This change provides: - Privacy: Non-admin users cannot see how many users are active - Performance: Reduces backend load by preventing API requests from non-admin users when the feature is enabled - Scalability: Significantly reduces /api/usage endpoint calls in deployments with hundreds of concurrent users Changes: - Backend: Add SHOW_ACTIVE_USERS_COUNT_ADMIN_ONLY env variable in env.py - Backend: Expose config setting via /api/config endpoint - Frontend: Check user role and config before displaying active user count - Frontend: Prevent API calls to /api/usage when user is not authorized Default behavior: Feature is disabled (false) to maintain backward compatibility. All users can see active user count unless explicitly restricted by setting SHOW_ACTIVE_USERS_COUNT_ADMIN_ONLY=true. Resolves open-webui#13026
Rename environment variable from SHOW_ACTIVE_USERS_COUNT_ADMIN_ONLY to ENABLE_ACTIVE_USERS_COUNT_ADMIN_ONLY to follow the established naming convention used throughout the codebase where feature flags start with ENABLE_. Changes: - Backend: Renamed env variable in env.py - Backend: Updated import and API response key in main.py - Frontend: Updated config key reference in UserMenu.svelte The functionality remains the same - when set to true, only admin users can see the active user count display.
Rename environment variable to ENABLE_PUBLIC_ACTIVE_USERS_COUNT and reverse the logic for better clarity and consistency with codebase naming conventions. Changes: - Variable: ENABLE_PUBLIC_ACTIVE_USERS_COUNT (default: "True") - When True (default): Everyone can see active user count (current behavior) - When False: Only admins can see active user count - Updated frontend logic to match reversed semantics This naming better follows the ENABLE_* pattern used throughout the codebase and makes the purpose more intuitive: "enable public visibility" is clearer than "enable admin-only restriction".
Add proper authorization check in the /api/usage endpoint to enforce access control when ENABLE_PUBLIC_ACTIVE_USERS_COUNT is disabled. Previously, the restriction was only enforced on the frontend, allowing users to bypass it by directly calling the API endpoint. Now: - When ENABLE_PUBLIC_ACTIVE_USERS_COUNT=false, only admins can access - Returns 403 Forbidden for non-admin users when restricted - Properly re-raises HTTPException to preserve status codes This completes the security implementation and ensures the performance benefits are fully realized by preventing unauthorized API access at the backend level.
Classic298
added a commit
that referenced
this pull request
Dec 20, 2025
…pen-webui#20027) * Merge pull request open-webui#19030 from open-webui/dev (#115) Co-authored-by: Tim Baek <[email protected]> Co-authored-by: Claude <[email protected]> Resolves open-webui#13026 * Claude/find active user count 1ct t1 (#116) Co-authored-by: Tim Baek <[email protected]> Co-authored-by: Claude <[email protected]> Resolves open-webui#13026 * Claude/find active user count 1ct t1 (#117) Co-authored-by: Tim Baek <[email protected]> Co-authored-by: Claude <[email protected]> Resolves open-webui#13026 --------- Co-authored-by: Tim Baek <[email protected]> Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.
This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.
Before submitting, make sure you've checked the following:
devbranch. Not targeting thedevbranch will lead to immediate closure of the PR.Changelog Entry
Description
Added
Changed
Deprecated
Removed
Fixed
Security
Breaking Changes
Additional Information
Screenshots or Videos
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.