Merge pull request open-webui#19030 from open-webui/dev#111
Merged
Classic298 merged 14 commits intoimage_urlfrom Dec 17, 2025
Merged
Merge pull request open-webui#19030 from open-webui/dev#111Classic298 merged 14 commits intoimage_urlfrom
Classic298 merged 14 commits intoimage_urlfrom
Conversation
chore: format
- Analyze current implementation of ENABLE_CHAT_RESPONSE_BASE64_IMAGE_URL_CONVERSION - Document how response images are converted from base64 to file URLs - Identify missing implementation for user input images - Explain access control for image files - Provide solution approach for converting user input images - Document expected performance improvements Related to GitHub discussion open-webui#13122
This implements Phase 1 of the solution for GitHub discussion open-webui#13122, which addresses the performance issue where large base64 images embedded in session data cause slow load times and poor browser performance. ## Changes Made ### Backend Changes: 1. **Environment Variable** (backend/open_webui/env.py) - Added ENABLE_CHAT_INPUT_BASE64_IMAGE_URL_CONVERSION (default: True) - Controls whether user input images are converted from base64 to file URLs 2. **Image Conversion Function** (backend/open_webui/utils/files.py) - Added convert_message_content_images() function - Handles both string content (markdown) and array content (OpenAI format) - Converts base64 images > 1024 chars to file URLs via upload_image() - Returns /api/v1/files/{id}/content URLs 3. **Chat History Converter** (backend/open_webui/models/chats.py) - Added _convert_chat_images() helper method - Processes both chat.messages[] and chat.history.messages{} - Applies conversion to all messages with image content - Includes error handling to prevent conversion failures from breaking chats 4. **Router Integration** (backend/open_webui/routers/chats.py) - Updated create_new_chat() - converts images on chat creation - Updated update_chat_by_id() - converts images on chat updates - Updated import_chats() - converts images in imported chats - All endpoints now accept Request parameter for conversion 5. **Documentation** (IMAGE_STORAGE_ANALYSIS.md) - Added implementation summary section - Documented all code changes with file locations and line numbers - Provided configuration instructions - Explained how the conversion works end-to-end ## Expected Performance Improvements - Session JSON size reduced from 100MB+ to <1MB - Chat load time improved from several seconds to <1 second - Images loaded on-demand with full browser caching support - Memory usage reduced (images not kept in memory) ## Backward Compatibility - Existing chats with base64 images continue to work - Conversion only applies to new/updated chats - Feature can be disabled via environment variable - Access control enforced via existing file permissions system Related to: open-webui#13122
- Simplified convert_message_content_images with early returns - Reduced nesting in _convert_chat_images using helper function - Removed redundant comments from router endpoints - Moved module imports from function body to top of file - Cleaner, more maintainable code structure
- Use .get() with defaults instead of isinstance before accessing - Chain .get() calls for nested dict access - Trust data structure with appropriate defaults - Cleaner, more Pythonic code
Move Chats imports from module-level to local scope to break circular dependency chain: models.chats → utils.files → routers.images → routers.files → models.users → models.chats Changes: - models/users.py: Move Chats import into delete_user_by_id() method - retrieval/utils.py: Move Chats import into chat type handler block This prevents ImportError at runtime while maintaining functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.
This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.
Before submitting, make sure you've checked the following:
devbranch. Not targeting thedevbranch will lead to immediate closure of the PR.Changelog Entry
Description
Added
Changed
Deprecated
Removed
Fixed
Security
Breaking Changes
Additional Information
Screenshots or Videos
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.