docs: Add comprehensive image storage analysis#110
Merged
Classic298 merged 3 commits intoperf-models-apifrom Dec 17, 2025
Merged
docs: Add comprehensive image storage analysis#110Classic298 merged 3 commits intoperf-models-apifrom
Classic298 merged 3 commits intoperf-models-apifrom
Conversation
- Analyze current implementation of ENABLE_CHAT_RESPONSE_BASE64_IMAGE_URL_CONVERSION - Document how response images are converted from base64 to file URLs - Identify missing implementation for user input images - Explain access control for image files - Provide solution approach for converting user input images - Document expected performance improvements Related to GitHub discussion open-webui#13122
Replace sequential database queries with batch loading in get_filtered_models() functions across utils/models.py, routers/openai.py, and routers/ollama.py. Changes: - Add ModelAccessControl response model for lightweight access control data - Add get_models_access_control_by_ids() method to fetch multiple models in a single query, excluding heavy meta field containing base64 images - Update three get_filtered_models() implementations to use batch loading instead of calling get_model_by_id() in a loop Performance Impact: - Reduces database queries from N to 1 (where N = number of models) - Excludes meta field with base64 profile images from access control checks - Significantly improves /api/models endpoint response time Fixes: open-webui#20004, open-webui#18950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.