Skip to content

-Wtautological-constant-compare in arch/s390/include/asm/page.h #860

@nathanchance

Description

@nathanchance
In file included from ../arch/s390/boot/compressed/decompressor.c:12:
../arch/s390/include/asm/page.h:43:6: warning: converting the result of '<<' to a boolean always evaluates to false [-Wtautological-constant-compare]
        if (PAGE_DEFAULT_KEY)
            ^
../arch/s390/include/asm/page.h:23:44: note: expanded from macro 'PAGE_DEFAULT_KEY'
#define PAGE_DEFAULT_KEY        (PAGE_DEFAULT_ACC << 4)
                                                  ^
1 warning generated.

This expression equals zero so I don’t understand how this code works at all (if it does?)

It has been this way since 0b642ed and it looks like the previous value was also zero? Seems like this check (and by extension, function) should just be removed but I’ll try to reach out to the IBM guys later and see what is up.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions