Skip to content

-Wstring-concatenation in drivers/clk/rockchip/clk-rk3228.c #1123

@nathanchance

Description

@nathanchance
../drivers/clk/rockchip/clk-rk3228.c:140:58: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation]
PNAME(mux_pll_src_4plls_p)      = { "cpll", "gpll", "hdmiphy" "usb480m" };
                                                              ^
                                                             ,
../drivers/clk/rockchip/clk-rk3228.c:140:48: note: place parentheses around the string literal to silence warning
PNAME(mux_pll_src_4plls_p)      = { "cpll", "gpll", "hdmiphy" "usb480m" };
                                                    ^
1 warning generated.

This is a new warning from LLVM. Seems sort of noisy but it pointed this out so I guess it is worth keeping around. I'll eventually get around to silencing the other instances that are not bugs (although I think putting parentheses around the literals will look ugly but so be it).

Patch submitted for this: https://lore.kernel.org/lkml/[email protected]/

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions