Repository navigation
fix(build): resolve node export conditions in rollup bundle - #2814
Merged
Merged
Conversation
Lightning00Blade
approved these changes
Sep 23, 2026
OrKoN
enabled auto-merge
September 23, 2026 10:10
pkce-challenge (a dependency of @modelcontextprotocol/client) defines package.json exports with only 'browser' and 'node' conditions and no 'default' condition. Because @rollup/plugin-node-resolve defaults to ['default', 'module', 'import'], it failed to resolve pkce-challenge during 'npm run bundle'. Rollup then emitted an UNRESOLVED_IMPORT warning and left an unbundled external 'import "pkce-challenge"' in build/src/third_party/index.js, causing the published npm package to fail at runtime with ERR_MODULE_NOT_FOUND. Configure nodeResolve with exportConditions: ['node'] and preferBuiltins: true, mark optional @puppeteer/browsers peer dependencies (proxy-agent, yauzl) as external, and fail the Rollup build on any UNRESOLVED_IMPORT warning.
OrKoN
force-pushed
the
orkon/fix-release
branch
from
September 23, 2026 10:12
24ea863 to
48a33c6
Compare
OrKoN
disabled auto-merge
September 23, 2026 10:24
OrKoN
pushed a commit
that referenced
this pull request
Sep 23, 2026
🤖 I have created a release *beep* *boop* --- ## [1.10.1](chrome-devtools-mcp-v1.10.0...chrome-devtools-mcp-v1.10.1) (2026-09-23) ### 🛠️ Fixes * **build:** resolve node export conditions in rollup bundle ([#2814](#2814)) ([d7c9b55](d7c9b55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
⚡⚡ god speed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkce-challenge (a dependency of @modelcontextprotocol/client) defines package.json exports with only 'browser' and 'node' conditions and no 'default' condition. Because @rollup/plugin-node-resolve defaults to ['default', 'module', 'import'], it failed to resolve pkce-challenge during 'npm run bundle'. Rollup then emitted an UNRESOLVED_IMPORT warning and left an unbundled external 'import "pkce-challenge"' in build/src/third_party/index.js, causing the published npm package to fail at runtime with ERR_MODULE_NOT_FOUND.
Configure nodeResolve with exportConditions: ['node'] and preferBuiltins: true, mark optional @puppeteer/browsers peer dependencies (proxy-agent, yauzl) as external, and fail the Rollup build on any UNRESOLVED_IMPORT warning.
Closes #2813