Repository navigation
feat(shared): use web components for search, select, and checkbox controls - #352
Merged
ChristopherVR merged 6 commits intoSep 24, 2026
Merged
Conversation
yunfeizhu
marked this pull request as draft
September 23, 2026 14:35
yunfeizhu
marked this pull request as ready for review
September 24, 2026 02:16
Contributor
Author
|
This ended up touching more files than I expected across the five bindings 😅 Getting the full CI matrix green was quite a journey, haha. Glad it finally made it through! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pptx-ui-search,pptx-ui-select, andpptx-ui-checkboxcustom elements. They use the existing--pptx-*theme tokens and provide one event and keyboard interaction contract across bindings.<style>fallback for DOMs without constructable stylesheet support.Verification
Closes #348
Closes #349
Related to #342