Repository navigation
fix(autosave): acknowledge restores and surface delete failures - #339
Merged
ChristopherVR merged 1 commit intoSep 21, 2026
Merged
ChristopherVR merged 1 commit into
ChristopherVR merged 1 commit into
Conversation
github-actions
Bot
added
react
ChristopherVR
approved these changes
Sep 21, 2026
ChristopherVR
left a comment
ChristopherVR
left a comment
Owner
There was a problem hiding this comment.
Reviewed the shared acknowledgement contract and all five bindings. The per-tab timestamp acknowledgement, retryable deletion path, and asynchronous restore rollback are correctly covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Keeps restored AutoSave snapshots as safety copies without offering the same bytes on every reload in the same tab. It records the exact restored
(document key, timestamp)insessionStorage, so documents remain independent, newer snapshots are still offered, and a fresh tab can still recover the preserved copy.It also makes
deleteAutosaveSnapshot()reject when an IndexedDB delete transaction errors, aborts, or throws. Recovery dialogs now stay open on deletion failure, while fire-and-forget lifecycle cleanup handles failures explicitly at its own boundary.Closes #337.
Closes #338.
Type of change
Cross-binding parity
Which bindings did you check, and what did you find?
packages/react)packages/vue)packages/angular)packages/svelte)packages/vanilla)UI fix
Testing
e2e/The browser regression restores a real IndexedDB snapshot, reloads the same tab without another prompt, confirms the snapshot is still stored, opens a fresh tab where it is offered again, and then explicitly discards it. React, Vue, and Angular passed all three recovery cases; Svelte and Vanilla also passed all three after their asynchronous-load acknowledgement path was finalized.
Deletion tests cover both an aborted IndexedDB transaction and a synchronous transaction-creation exception. Binding tests verify that failed discard leaves the recovery prompt available for retry.
Checks run locally
oxfmt --check)oxlint; existing unrelated warnings only, changed JS/TS files also pass--deny-warnings)Full package test results:
Conventional Commits