Repository navigation
fix(pptx): persist canvas size changes from automation - #252
Merged
ChristopherVR merged 1 commit intoNov 6, 2026
Merged
Conversation
Pass the requested slide dimensions to the save pipeline and keep the in-memory pixel dimensions in sync. Reject sizes outside the slide coordinate range and verify the registered tool against a saved deck.
github-actions
Bot
added
tests
commit: |
Contributor
Bundle size4 of 67 entry points changed size against main (6c75692):
All entry points
Each entry point with the files it imports statically, gzipped, before minification. Measured by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #250.
Carry
set_canvas_sizethrough to the savedp:sldSz. A 720 × 480 point request now saves 9144000 × 6096000 EMU and reloads at the requested dimensions. Keep the model's pixel dimensions in sync and validate the PPTX slide coordinate range.Testing
The shared UI token check reports
office-ui-status-bar: 1px, -1pxon both the branch and the unchanged6c75692a6base. The PPTX package steps that stopped after this assertion were run separately and passed.Fork CI · Reproduction ZIP