Repository navigation
fix(pptx): keep custom show hyperlinks in sync - #246
Merged
ChristopherVR merged 1 commit intoNov 4, 2026
Merged
Conversation
Update canonical text links, action metadata and default styles together. Rewrite preserved table-cell links during show deletion and id normalization, preserving rich text and unrelated hyperlink metadata. Exercise the registered tool and save/reload path using a real deck.
github-actions
Bot
added
tests
commit: |
Contributor
Bundle size4 of 67 entry points changed size against main (5b031d7):
All entry points
Each entry point with the files it imports statically, gzipped, before minification. Measured by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #244.
Keep canonical text hyperlinks, their action metadata and default text styles consistent when a custom show is deleted or remapped. Rewrite table-cell links in preserved DrawingML as well, without rebuilding the cell's rich text or fields. Deleted shows leave no saved jumps, and normalized show IDs are reflected in shape, text and table targets.
Type of change
Area
pptx. Shared custom-show URI handling is reused by shape, modeled text and preserved table links.
Testing
manage_custom_showsdelete andPptxHandlersave/reload cover shape, text and table jumps plus host-ID normalizationbun run verify --base 5b031d7c377b3d0679558b59b799304c467c8425 --jobs 2: all 23 planned local steps passed, including lint, changed-file formatting, typechecks, affected core/UI tests and PPTX package checks/buildsThe default local verifier skips browser suites and package smoke checks. Scoped fork CI is running those additional planned checks on
a998bde91ff14042f48c0d3a400ec430a77ca010.Reproduction case
Input PPTX, saved before/after outputs, XML, verification report and runnable script.
The committed
custom-show-hyperlinks.pptxis the actual input read by the round-trip regression, including the rich-text/field preservation case. Screenshots and generated output files are not committed.Conventional Commits