allow ability to select aur helper#189
allow ability to select aur helper#189ChrisTitusTech merged 10 commits intoChrisTitusTech:serverfrom godalming123:allow-ability-to-select-aur-helper
Conversation
|
great option to add! |
|
I like the idea, but it might be executed maybe a little bit differently. At least it looks easy enough, and also possibly includes every AUR helper from arch? For 2-user.sh: and for startup.sh |
Yes true |
Also true |
That is a god idea. I think I will add a |
I like this idea of implementation too. But, I'd recommend following a more strict input validation otherwise your just going to pass through whatever inputted name is to all referenced locations. EDIT: But, I wouldn't say it's anything to hold up PR over in the end, can be a further enhancement. Just would recommend fixing up bug and can leave hard coded values with normal read input. Then you could enhance the validation and stuff after. Just my opinion. |
|
Yeah, I thought of that, too. This would be good for not limiting AUR helpers, but then again, it doesn't have any validation. Maybe it should check if git command actually passed and created a folder, if not, return to selection?
If directory exists, git command worked and the script goes on, if dir does not exist, return to selection. |
Yeah, I was thinking along the lines of something like #182 where I'm checking if the option is part of the list of options provided. So, we populate the list of aur helpers and make sure they choose from the list. |
|
I have fixed the bug on line 42 and added checking so the user cannot enter the incorrectly and an other option. |
|
I managed to figure out why my script was skipping straight to the in |
|
@ChrisTitusTech I think you should undo these changes. The branch installs but doesn't install the AUR helper when I tried my branch this morning and executed just user.sh it couldn't run so it doesn't install the AUR helper as that's where it installs it. |
|
@ChrisTitusTech the 681f14c commit appears to fix everything but I am still testing |
|
I have created a new PR #222 to fix the bug |
This is a fork that adds the ability to select what aur helper you would like to use currently the options are:
If anyone wants any other AUR helpers please let me know.
And thanks @ChrisTitusTech for creating this awesome script!