refactor(sidebar): add reusable Sidebar UI component with responsive layouts#13879
Draft
jidan745le wants to merge 2 commits intoCherryHQ:v2from
Draft
refactor(sidebar): add reusable Sidebar UI component with responsive layouts#13879jidan745le wants to merge 2 commits intoCherryHQ:v2from
jidan745le wants to merge 2 commits intoCherryHQ:v2from
Conversation
…earch functionality Signed-off-by: kangfenmao <[email protected]>
Signed-off-by: jidan745le <[email protected]>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Sidebar.tsx@cherrystudio/ui/app/agentsand/app/openclawcaused "Page Not Found" when clicking those menu itemsAfter this PR:
Sidebarcomponent topackages/ui/src/components/sidebar/with:useSidebarDraghook for docking/undocking tabs to/from the sidebaruseSidebarTabshook for managing sidebar tabs and mini-app tabsSidebar.tsxto consume the newUISidebarcomponentWhy we need it and why it was done in this way
The v2 UI migration requires moving from antd/styled-components to
@cherrystudio/ui(Tailwind + Shadcn). The sidebar is a core navigation component that benefits from being a reusable, well-structured UI primitive in the shared package.The following tradeoffs were made:
packages/uirather than inline in the app, to enable reuse across windows (main, mini) and easier testingThe following alternatives were considered:
Breaking changes
None. This builds on top of the sidebar-simplify refactor.
Special notes for your reviewer
refactor/v2/sidebar-simplify(upstream) which fixed the agents/openclaw routinguseSidebarDraganduseSidebarTabshooks are not yet fully wired into the app-level codeChecklist
Release note
```release-note
NONE
```