fix(ci): add Linux system deps for selection-hook native rebuild#13855
Merged
fix(ci): add Linux system deps for selection-hook native rebuild#13855
Conversation
Install libevdev-dev, libxtst-dev, libx11-dev, libxfixes-dev, and libwayland-dev on ubuntu-latest so the selection-hook native module can be compiled during the Linux release build. Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: suyao <[email protected]>
EurFelux
approved these changes
Mar 27, 2026
![cherry-ai-bot[bot]](https://avatars.githubusercontent.com/in/3013849?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM. This CI fix is narrowly scoped and correctly adds the Linux system development packages needed for rebuilding the selection-hook native module during the release build. I did not find any blocking issues in the workflow change.
Minor follow-up risk to watch: if selection-hook or related native dependencies require any additional system libraries on GitHub-hosted Ubuntu runners, the release job may still surface a different missing-package error, but that does not block this PR as written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libevdev-dev,libxtst-dev,libx11-dev,libxfixes-dev, andlibwayland-devin the Linux release build step so theselection-hooknative module compiles successfully.Test plan
workflow_dispatchand verify it completes without native module compilation errors.🤖 Generated with Claude Code