fix(aiCore): add missing @openrouter/ai-sdk-provider dependency#13787
Merged
fix(aiCore): add missing @openrouter/ai-sdk-provider dependency#13787
Conversation
The package is imported in aiCore source but was not declared in its package.json, causing tsdown to bundle it and fail the Release Packages CI workflow. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: icarus <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: icarus <[email protected]>
DeJeune
approved these changes
Mar 25, 2026
GeorgeDong32
approved these changes
Mar 26, 2026
kangfenmao
added a commit
that referenced
this pull request
Mar 26, 2026
<!-- Template from https://github.com/kubevirt/kubevirt/blob/main/.github/PULL_REQUEST_TEMPLATE.md?--> <!-- Thanks for sending a pull request! Here are some tips for you: 1. Consider creating this PR as draft: https://github.com/CherryHQ/cherry-studio/blob/main/CONTRIBUTING.md --> <!--⚠️ Important: Redux/IndexedDB Data-Changing Feature PRs Temporarily On Hold⚠️ Please note: For our current development cycle, we are not accepting feature Pull Requests that introduce changes to Redux data models or IndexedDB schemas. While we value your contributions, PRs of this nature will be blocked without merge. We welcome all other contributions (bug fixes, perf enhancements, docs, etc.). Thank you! Once version 2.0.0 is released, we will resume reviewing feature PRs. --> ### What this PR does Before this PR: - Version was at 1.8.3 After this PR: - Bumps version to 1.8.4 - Updates release notes with bilingual (English/Chinese) content ### Release Notes Cherry Studio 1.8.4 - Bug Fixes and New Features **English:** - [API] Add knowledge base REST API endpoints - [SelectionAssistant] Add Linux support for text selection toolbar - [Files] Fix PDF upload failing with "invalid part type: file" error for OpenAI-compatible providers (Moonshot, DeepSeek, Groq, etc.) **Chinese:** - [API] 添加知识库 REST API 端点 - [选择助手] 为文本选择工具栏添加 Linux 支持 - [文件] 修复 OpenAI 兼容提供商(Moonshot、DeepSeek、Groq 等)的 PDF 上传失败问题("invalid part type: file" 错误) ### Included Commits 1. fix(aiCore): remove openai-compatible providers from PDF native support list (#13809) 2. feat(api): add knowledge base REST API endpoints (#13762) 3. feat(SelectionAssistant): Linux support (#13720) 4. fix(aiCore): add missing @openrouter/ai-sdk-provider dependency (#13787) (Skipped internal CI/CD changes) ### Review Checklist - [ ] Review generated release notes in `electron-builder.yml` - [ ] Verify version bump in `package.json` - [ ] CI passes - [ ] Merge to trigger release build ### Checklist This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list. - [x] PR: The PR description is expressive enough and will help future contributors - [x] Code: [Write code that humans can understand](https://en.wikiquote.org/wiki/Martin_Fowler#code-for-humans) and [Keep it simple](https://en.wikipedia.org/wiki/KISS_principle) - [x] Refactor: You have [left the code cleaner than you found it (Boy Scout Rule)](https://learning.oreilly.com/library/view/97-things-every/9780596809515/ch08.html) - [x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required - [x] Documentation: A [user-guide update](https://docs.cherry-ai.com) was considered and is present (link) or not required. Check this only when the PR introduces or changes a user-facing feature or behavior. - [x] Self-review: I have reviewed my own code (e.g., via [`/gh-pr-review`](/.claude/skills/gh-pr-review/SKILL.md), `gh pr diff`, or GitHub UI) before requesting review from others ### Release note ```release-note Cherry Studio 1.8.4 - Bug Fixes and New Features ✨ New Features - [API] Add knowledge base REST API endpoints - [SelectionAssistant] Add Linux support for text selection toolbar 🐛 Bug Fixes - [Files] Fix PDF upload failing with "invalid part type: file" error for OpenAI-compatible providers (Moonshot, DeepSeek, Groq, etc.) ``` Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
MyPrototypeWhat
pushed a commit
that referenced
this pull request
Mar 30, 2026
### What this PR does Before this PR: The `@cherrystudio/ai-core` package imports `@openrouter/ai-sdk-provider` in its source code (`schemas.ts` and `types.ts`), but this dependency was not declared in `packages/aiCore/package.json`. This caused `tsdown` to inline-bundle it and exit with an error, failing the **Release Packages** CI workflow. After this PR: `@openrouter/ai-sdk-provider` is properly declared as a dependency in `packages/aiCore/package.json`, so `tsdown` treats it as an external dependency and the build succeeds. Fixes # N/A ### Why we need it and why it was done in this way The following tradeoffs were made: None — this is a straightforward missing dependency declaration. The following alternatives were considered: None. Links to places where the discussion took place: N/A ### Breaking changes None. ### Special notes for your reviewer The root `package.json` already has `@openrouter/ai-sdk-provider@^2.2.3` with a patch applied. The aiCore package now correctly declares the same version range so it resolves through the workspace. ### Checklist - [x] PR: The PR description is expressive enough and will help future contributors - [x] Code: [Write code that humans can understand](https://en.wikiquote.org/wiki/Martin_Fowler#code-for-humans) and [Keep it simple](https://en.wikipedia.org/wiki/KISS_principle) - [x] Refactor: You have [left the code cleaner than you found it (Boy Scout Rule)](https://learning.oreilly.com/library/view/97-things-every/9780596809515/ch08.html) - [x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required - [ ] Documentation: A [user-guide update](https://docs.cherry-ai.com) was considered and is present (link) or not required. Check this only when the PR introduces or changes a user-facing feature or behavior. - [x] Self-review: I have reviewed my own code (e.g., via [`/gh-pr-review`](/.claude/skills/gh-pr-review/SKILL.md), `gh pr diff`, or GitHub UI) before requesting review from others ### Release note ```release-note NONE ``` --------- Signed-off-by: icarus <[email protected]> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The
@cherrystudio/ai-corepackage imports@openrouter/ai-sdk-providerin its source code (schemas.tsandtypes.ts), but this dependency was not declared inpackages/aiCore/package.json. This causedtsdownto inline-bundle it and exit with an error, failing the Release Packages CI workflow.After this PR:
@openrouter/ai-sdk-provideris properly declared as a dependency inpackages/aiCore/package.json, sotsdowntreats it as an external dependency and the build succeeds.Fixes #
N/A
Why we need it and why it was done in this way
The following tradeoffs were made:
None — this is a straightforward missing dependency declaration.
The following alternatives were considered:
None.
Links to places where the discussion took place:
N/A
Breaking changes
None.
Special notes for your reviewer
The root
package.jsonalready has@openrouter/ai-sdk-provider@^2.2.3with a patch applied. The aiCore package now correctly declares the same version range so it resolves through the workspace.Checklist
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note