Conversation
DeJeune
approved these changes
Mar 23, 2026
Collaborator
Author
|
Note This issue/comment/review was translated by Claude. There are quite a few false positives, let's put this aside for now. Original ContentFalse Positive 有点多,先放放 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
66af36c to
7a636a2
Compare
7a636a2 to
a673f9a
Compare
a673f9a to
b846b16
Compare
b846b16 to
66d3840
Compare
GeorgeDong32
approved these changes
Mar 25, 2026
MyPrototypeWhat
pushed a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The
typescript/no-unnecessary-type-assertionrule was not enabled in oxlint, allowing redundantas Xtype assertions throughout the codebase.After this PR:
typescript/no-unnecessary-type-assertionaserrorin.oxlintrc.jsonWhy we need it and why it was done in this way
Unnecessary type assertions add noise and can mask real type issues. Enabling this lint rule keeps the codebase cleaner and ensures TypeScript's type inference is trusted where it's already correct.
The following tradeoffs were made: None
The following alternatives were considered: None
Breaking changes
None
Special notes for your reviewer
All changes were auto-fixed by the linter. The only manual change is the rule addition in
.oxlintrc.json.Checklist
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note