fix: override @napi-rs/canvas to 0.1.97 for Windows ARM64 support#13723
Merged
fix: override @napi-rs/canvas to 0.1.97 for Windows ARM64 support#13723
Conversation
DeJeune
approved these changes
Mar 22, 2026
Contributor
There was a problem hiding this comment.
This change looks reasonable to me. The override is narrowly scoped, matches the stated goal of restoring Windows ARM64 support, and the lockfile updates are consistent with the package.json change.
I did not find a blocking correctness issue in the diff.
Minor note only: the lockfile also changes a transitive semver entry from 7.7.2 to 7.7.1, which appears to be a resolver side effect rather than an intentional change, but it is worth keeping an eye on in CI/platform verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
[email protected]depends on@napi-rs/[email protected], which does not include Windows ARM64 support. This causes issues for Windows ARM64 users.After this PR:
Adds a pnpm override to force
@napi-rs/canvasto0.1.97, which includes Windows ARM64 support.Upstream issue: mehmet-kozan/pdf-parse#106
Why we need it and why it was done in this way
The following tradeoffs were made:
Using pnpm
overridesinstead of waiting for an upstreampdf-parserelease, since the maintainer has not published a new version despite the fix being available.The following alternatives were considered:
pdf-parseto release a new version — not feasible as the package appears unmaintained.pdf-parse— unnecessary overhead for a single transitive dependency version bump.Links to places where the discussion took place: mehmet-kozan/pdf-parse#106
Breaking changes
None.
Special notes for your reviewer
This is a workaround. The root cause is that
pdf-parsepins an old version of@napi-rs/canvasthat lacks Windows ARM64 binaries. The override is safe as@napi-rs/[email protected]is a backward-compatible minor update.Checklist
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note