Skip to content

fix: override @napi-rs/canvas to 0.1.97 for Windows ARM64 support#13723

Merged
DeJeune merged 1 commit intomainfrom
fix/canvas-patch
Mar 23, 2026
Merged

fix: override @napi-rs/canvas to 0.1.97 for Windows ARM64 support#13723
DeJeune merged 1 commit intomainfrom
fix/canvas-patch

Conversation

@EurFelux
Copy link
Copy Markdown
Collaborator

@EurFelux EurFelux commented Mar 22, 2026

What this PR does

Before this PR:

[email protected] depends on @napi-rs/[email protected], which does not include Windows ARM64 support. This causes issues for Windows ARM64 users.

After this PR:

Adds a pnpm override to force @napi-rs/canvas to 0.1.97, which includes Windows ARM64 support.

Upstream issue: mehmet-kozan/pdf-parse#106

Why we need it and why it was done in this way

The following tradeoffs were made:

Using pnpm overrides instead of waiting for an upstream pdf-parse release, since the maintainer has not published a new version despite the fix being available.

The following alternatives were considered:

  • Waiting for pdf-parse to release a new version — not feasible as the package appears unmaintained.
  • Forking pdf-parse — unnecessary overhead for a single transitive dependency version bump.

Links to places where the discussion took place: mehmet-kozan/pdf-parse#106

Breaking changes

None.

Special notes for your reviewer

This is a workaround. The root cause is that pdf-parse pins an old version of @napi-rs/canvas that lacks Windows ARM64 binaries. The override is safe as @napi-rs/[email protected] is a backward-compatible minor update.

Checklist

Release note

NONE

@EurFelux EurFelux requested a review from DeJeune March 22, 2026 16:56
Copy link
Copy Markdown
Contributor

@cherry-ai-bot cherry-ai-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks reasonable to me. The override is narrowly scoped, matches the stated goal of restoring Windows ARM64 support, and the lockfile updates are consistent with the package.json change.

I did not find a blocking correctness issue in the diff.

Minor note only: the lockfile also changes a transitive semver entry from 7.7.2 to 7.7.1, which appears to be a resolver side effect rather than an intentional change, but it is worth keeping an eye on in CI/platform verification.

@DeJeune DeJeune merged commit af34584 into main Mar 23, 2026
11 checks passed
@DeJeune DeJeune deleted the fix/canvas-patch branch March 23, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants