Skip to content

fix: agent session auto renaming feedback#13707

Merged
DeJeune merged 2 commits intoCherryHQ:mainfrom
alephpiece:fix/agent-session-auto-renaming-feedback
Mar 22, 2026
Merged

fix: agent session auto renaming feedback#13707
DeJeune merged 2 commits intoCherryHQ:mainfrom
alephpiece:fix/agent-session-auto-renaming-feedback

Conversation

@alephpiece
Copy link
Copy Markdown
Collaborator

@alephpiece alephpiece commented Mar 22, 2026

What this PR does

Adds back the revealing animation to agent session renaming.

  • Animation typing is improved using clip-path and renamed to reveal.
  • shimmer and reveal animations are extracted to animation.css.
  • These animiations are applied to agent session renaming.

Before this PR:

There is no feedback on agent session renaming.

After this PR:

Same animation feedbacks on renaming topic, session, and note items.

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

Add the revealing animation to agent session renaming.

Copy link
Copy Markdown
Collaborator

@GeorgeDong32 GeorgeDong32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码审查总结

✅ 优点

  1. 代码复用优秀 - 将 shimmerreveal 动画抽离到 animation.css,消除了 Topics.tsxTreeNode.tsx 中的 75 行重复样式代码

  2. 动画实现改进 - 新的 reveal 动画使用 clip-path 实现,比原来的 typewriter 动画更现代、性能更好

  3. 状态管理规范 - 使用 try/finally 确保重命名状态正确清理

  4. 命名一致性 - 统一使用 animation- 前缀,与现有动画风格一致

📝 建议(非阻塞)

  • SessionItem.tsx:130-141renameAgentSessionIfNeeded 的错误处理可以添加 catch 块,以便在失败时给用户反馈

总体评价

代码质量良好,架构清晰,建议批准。

@kangfenmao
Copy link
Copy Markdown
Collaborator

Release notes need update

@DeJeune DeJeune merged commit 1f97e8e into CherryHQ:main Mar 22, 2026
11 checks passed
@alephpiece alephpiece deleted the fix/agent-session-auto-renaming-feedback branch March 22, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants