fix: agent session auto renaming feedback#13707
Merged
DeJeune merged 2 commits intoCherryHQ:mainfrom Mar 22, 2026
Merged
Conversation
GeorgeDong32
approved these changes
Mar 22, 2026
Collaborator
GeorgeDong32
left a comment
There was a problem hiding this comment.
代码审查总结
✅ 优点
-
代码复用优秀 - 将
shimmer和reveal动画抽离到animation.css,消除了Topics.tsx和TreeNode.tsx中的 75 行重复样式代码 -
动画实现改进 - 新的
reveal动画使用clip-path实现,比原来的typewriter动画更现代、性能更好 -
状态管理规范 - 使用
try/finally确保重命名状态正确清理 -
命名一致性 - 统一使用
animation-前缀,与现有动画风格一致
📝 建议(非阻塞)
SessionItem.tsx:130-141中renameAgentSessionIfNeeded的错误处理可以添加catch块,以便在失败时给用户反馈
总体评价
代码质量良好,架构清晰,建议批准。
Collaborator
|
Release notes need update |
DeJeune
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds back the revealing animation to agent session renaming.
typingis improved using clip-path and renamed toreveal.shimmerandrevealanimations are extracted toanimation.css.Before this PR:
There is no feedback on agent session renaming.
After this PR:
Same animation feedbacks on renaming topic, session, and note items.
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Breaking changes
If this PR introduces breaking changes, please describe the changes and the impact on users.
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note