fix: add @napi-rs/canvas to avoid dependency missing on dev startup#13685
Merged
DeJeune merged 1 commit intoCherryHQ:mainfrom Mar 21, 2026
Merged
fix: add @napi-rs/canvas to avoid dependency missing on dev startup#13685DeJeune merged 1 commit intoCherryHQ:mainfrom
DeJeune merged 1 commit intoCherryHQ:mainfrom
Conversation
GeorgeDong32
approved these changes
Mar 21, 2026
kangfenmao
approved these changes
Mar 21, 2026
Collaborator
|
Note This issue/comment/review was translated by Claude. This is an indirect dependency, it's better not to include it in the declaration. We have a simpler solution now, which is to put Original Content这个是间接依赖,最好不放声明里。我们现在有一个更简单的解决方案是把 |
Collaborator
|
Note This issue/comment/review was translated by Claude. That's awkward, I acted too quickly Original Content难绷,手快了 |
This was referenced Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Add napi-rs/canvas to dependency to avoid dev startup crash
Before this PR:
After this PR:
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Breaking changes
If this PR introduces breaking changes, please describe the changes and the impact on users.
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note