feat: show model ids for duplicate names in model pickers#13654
Merged
kovsu merged 7 commits intoCherryHQ:mainfrom Mar 25, 2026
Merged
feat: show model ids for duplicate names in model pickers#13654kovsu merged 7 commits intoCherryHQ:mainfrom
kovsu merged 7 commits intoCherryHQ:mainfrom
Conversation
Use useMemo to compute the combined unique models list (uniqBy) with dependencies [provider.id, listModels, models] to avoid unnecessary recomputation. Also remove an unnecessary `!important` from the monospace font-size in ModelIdWithTags to rely on normal stylesheet precedence and simplify styling.
Collaborator
|
conflicts |
EurFelux
reviewed
Mar 23, 2026
Collaborator
EurFelux
left a comment
EurFelux
left a comment
There was a problem hiding this comment.
整体质量不错！逻辑清晰，getDuplicateModelNames 工具函数抽取合理，useMemo 使用恰当。提了四个建议：一致性防护、TailwindCSS 样式偏好、多余的 re-export、以及新函数的测试覆盖。
Signed-off-by: Konv Suu <[email protected]>
MyPrototypeWhat
pushed a commit
that referenced
this pull request
Mar 30, 2026
Co-authored-by: Pleasurecruise <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13647