fix: disable thinking mode for LLM language detection#13565
Merged
Conversation
- Validate model exists before using it for language detection - Set reasoning_effort to 'none' for language detection to improve performance - Remove unused import of getDefaultModel
DeJeune
approved these changes
Mar 17, 2026
GeorgeDong32
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Language detection via LLM used
getQuickModel() || getDefaultModel()without validating model availability, and did not disable thinking/reasoning mode. This caused issues when most modern models default to thinking mode, making model selection difficult for language detection.After this PR:
hasModel()reasoning_effort: 'none'to explicitly disable thinking mode for language detectiongetDefaultModelimportFixes #13562
Why we need it and why it was done in this way
The following tradeoffs were made:
getDefaultModel()fallback — language detection should only use the explicitly configured quick model, not silently fall back to the default model which may be slow/expensive.The following alternatives were considered:
reasoning_effort: 'none'in assistant settings is the existing pattern used elsewhere in the codebase.Breaking changes
None.
Special notes for your reviewer
Small, focused fix. Only modifies
src/renderer/src/utils/translate.ts.Checklist
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note