fix: Windows Terminal launch fails on non-English systems#13551
fix: Windows Terminal launch fails on non-English systems#13551GeorgeDong32 merged 2 commits intomainfrom
Conversation
…non-English systems The `-p "Command Prompt"` flag fails on localized Windows (e.g. Chinese "命令提示符"). Use default profile instead and fix extra quoting of bat file path. Closes #13550 Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
Note This comment was translated by Claude. It may not be entirely a profile issue, the problem is that the profile wasn't "quoted". #13400 should be able to fix it. If removed, if the user's Windows Terminal default profile is wsl, it might not start cmd. I'll try it again tonight. Original Content可能不完全是 profile 这个问题，是 profile 没有 "quote" 起来。 #13400 应该能修掉，去掉的话如果用户 Windows Terminal 默认profile是wsl可能会启动不了cmd，我晚上再试试 |
|
Note This comment was translated by Claude. Thank you for the feedback! You make a good point. Removing Looking at the changes in #13400, simply removing the extra quotes while keeping However, I have one question: if the root cause is just the quotes issue, can |
|
@DeJeune This is the issue we privately discussed on WeChat. I am tagging you to bring it to your attention, as you may be working on the same issue, or at least have been looking into this. Hope it helps! |
|
Note This comment was translated by Claude. I suddenly discovered that the last commit in #13400 wasn't pushed, causing the fix to still fail 😢. However, I tested this method and it seems to work. The Windows Terminal started by spawn seems different from what the documentation says - it doesn't use the user's default profile, but uses PowerShell instead, so theoretically there shouldn't be the issue of WSL lacking cmd to start. Original Content突然发现 #13400 最后有个提交没push，导致修复还是失败的 😢 。但是我测了一下这种方法好像也行，spwan启动的的Windows Terminal貌似和文档里说的不一样，不会使用用户设置的默认配置文件，而是使用Powershell，因此理论上不会有WSL缺少cmd启动不了的问题 |
|
Note This comment was translated by Claude. What was the issue with the previous PR? I can start Claude Code normally on my Win11 virtual machine. Original Content之前那个pr有啥问题，我用win11虚拟机能够正常启动claude code啊 |
Note This comment was translated by Claude. The issue with the previous PR was that Original Content之前那个 PR 的 -p Command Prompt 没有 quote 起来，会导致启动 Windows Terminal 的时候误认为 Prompt 是另一个入参。仅当选择 Windows Terminal 的时候会出现这个问题 |
4 participants
Summary
Fix
Use default Windows Terminal profile instead of hardcoding English profile name.
Closes #13550
Test plan