Skip to content

fix(azure): keep dated api versions on chat transport#13506

Merged
DeJeune merged 1 commit intomainfrom
fix/azure-dated-api-chat-transport-13499-clean
Mar 16, 2026
Merged

fix(azure): keep dated api versions on chat transport#13506
DeJeune merged 1 commit intomainfrom
fix/azure-dated-api-chat-transport-13499-clean

Conversation

@cherry-ai-bot
Copy link
Copy Markdown
Contributor

@cherry-ai-bot cherry-ai-bot bot commented Mar 16, 2026

Summary

Fix the Azure OpenAI regression reported in #13499.

Dated Azure API versions such as 2024-12-01-preview are intended to stay on Cherry's chat / deployment-based path, while only generic preview / v1 should use the Responses API. The regression was that aiCore's internal azure provider still defaulted to the Responses transport, so deployment-based Azure requests could still generate /openai/deployments/<deployment>/responses URLs and fail with 404.

This PR restores the intended split by:

  • making the azure provider default to provider.chat(...)
  • keeping azure-responses on provider.responses(...)
  • aligning the registry's azure-chat fallback with the same chat wrapper
  • adding regression coverage for provider routing and registry behavior

Verification

  • node node_modules/vitest/vitest.mjs run --project renderer src/renderer/src/aiCore/provider/__tests__/providerConfig.test.ts
  • node node_modules/vitest/vitest.mjs run --project aiCore packages/aiCore/src/core/providers/__tests__/registry-functionality.test.ts

Fixes #13499

Copy link
Copy Markdown
Collaborator

@DeJeune DeJeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeJeune DeJeune requested a review from EurFelux March 16, 2026 08:47
@DeJeune DeJeune merged commit 83d7575 into main Mar 16, 2026
10 checks passed
@DeJeune DeJeune deleted the fix/azure-dated-api-chat-transport-13499-clean branch March 16, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Azure OpenAI settings work in v1.7.19 but fail in v1.7.25

2 participants