fix: remove 32-char truncation for user-defined filter paths#13423
Merged
DeJeune merged 1 commit intoCherryHQ:mainfrom Mar 12, 2026
Merged
fix: remove 32-char truncation for user-defined filter paths#13423DeJeune merged 1 commit intoCherryHQ:mainfrom
DeJeune merged 1 commit intoCherryHQ:mainfrom
Conversation
Previously, user-defined application paths in the Selection Toolbar filter list were being truncated to 32 characters due to .slice(0, 32). This caused paths with spaces like 'C:\Program Files\Microsoft Office\...' to be saved incorrectly as 'c:\program files\microsoft offi'. This fix removes the arbitrary character limit to allow full Windows/Mac application paths to be stored correctly. Fixes: CherryHQ#13372
DeJeune
approved these changes
Mar 12, 2026
![cherry-ai-bot[bot]](https://avatars.githubusercontent.com/in/3013849?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This is a focused fix for a clearly incorrect normalization step. Removing the arbitrary 32-character truncation restores expected behavior for real Windows/macOS application paths while keeping the existing trim/lowercase/split/dedup flow unchanged. LGTM ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, user-defined application paths in the Selection Toolbar filter list were being truncated to 32 characters due to
.slice(0, 32). This caused paths with spaces likeC:\Program Files\Microsoft Office\...to be saved incorrectly asc:\program files\microsoft offi.Fix
This fix removes the arbitrary character limit to allow full Windows/Mac application paths to be stored correctly.
Testing
Manual testing:
C:\Program Files\Microsoft Office\root\Office16\WINWORD.EXERelated Issue
Fixes #13372