Code Review Summary

PR Title: fix: preserve emoji when saving assistant to library
Author: kovsu
Related Issue: #13367

Overview

This PR addresses an issue where migration v73 moved leading emoji from `assistant.name` into `assistant.emoji` and trimmed the name. The save-to-library flow was omitting the `emoji` field, causing the migrated value to be lost.

Files Changed (2)

Review Analysis

1. Main Fix: AssistantItem.tsx (Line 317)

```diff

• const preset = omit(assistant, ['model', 'emoji'])

• const preset = omit(assistant, ['model'])
  ```

Assessment: ✅ Correct and Minimal

• The fix correctly preserves the `emoji` field when saving an assistant to the library
• Follows the migration pattern established in v73
• Change is minimal and focused on the specific issue
• The `model` field is still correctly excluded (likely to allow library items to have their own model selection)

Logic Verification:

• The `omit()` function from lodash creates a new object without the specified keys
• Previously, `emoji` was being stripped, causing data loss after migration
• Now the emoji is preserved in the saved preset

2. SidebarIconsManager.tsx - Icon Update

```diff

• import { Bot, ... } from 'lucide-react'

• import { OpenClawSidebarIcon } from '@renderer/components/Icons/SVGIcon'
  ...

• openclaw:

• openclaw: <OpenClawSidebarIcon style={{ width: 16, height: 16 }} />
  ```

Assessment: ✅ Acceptable (minor UI improvement)

• While not directly related to the emoji preservation fix, this is a reasonable UI polish
• Uses consistent import pattern for custom icons
• Properly styled with inline styles for sizing

Note: This change seems unrelated to the main PR purpose but is harmless and improves UI consistency.

Checklist Evaluation

Recommendations

1. (Optional) Add test coverage: Consider adding a unit test that verifies the `emoji` field is preserved when saving to library.

2. (Optional) Separate concerns: The SidebarIconsManager change could be in a separate PR for cleaner git history, but it's acceptable as-is for a small UI fix.

Verdict

✅ Approved

This is a clean, minimal fix that directly addresses the reported issue. The code follows existing patterns and introduces no regressions. The change is safe to merge.

Reviewed by kimi-k2.5