fix: add warning for temporarily unavailable Anthropic OAuth authentication#13331
Merged
fix: add warning for temporarily unavailable Anthropic OAuth authentication#13331
Conversation
…cation Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: icarus <[email protected]>
DeJeune
approved these changes
Mar 9, 2026
This comment was marked as duplicate.
This comment was marked as duplicate.
Collaborator
|
Note This comment was translated by Claude. Code Review SummaryOverall Assessment: Code quality is good and meets project standards ✅ Overview of Changes
Strengths
Suggestions (Non-blocking)The current implementation displays the warning regardless of authentication status. It is recommended to consider conditional display, showing the warning only to unauthenticated users ( Review Results
Conclusion: Ready to merge Original Content代码审查总结整体评价: 代码质量良好,符合项目规范 ✅ 变更概述
优点
建议 (非阻塞)当前实现无论认证状态如何都会显示警告。建议考虑条件显示,仅对未认证用户 (authStatus === NOT_STARTED 或 AUTHENTICATING) 显示警告,因为已认证用户可能不需要看到此提示。 审查结果
结论: 可以合并 |
GeorgeDong32
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Users selecting Anthropic OAuth authentication had no indication that the method is currently unavailable.
After this PR:
A warning alert is displayed when users select OAuth authentication for Anthropic, informing them that OAuth is temporarily suspended and they should use an API key instead.
Why we need it and why it was done in this way
Anthropic has temporarily disabled the use of Claude via OAuth. Users attempting to authenticate via OAuth would encounter failures without understanding why. A visible warning alert is the simplest and most direct way to communicate this to users.
The following tradeoffs were made:
The following alternatives were considered:
Breaking changes
None.
Special notes for your reviewer
Minimal change: one warning
Alertadded toAnthropicSettings.tsx+ one i18n key (oauth_disabled_warning) added across all locales.Checklist
Release note