Skip to content

fix(i18n): clarify tool permission title as 'Pre-approved Tools'#13327

Merged
EurFelux merged 1 commit intomainfrom
fix/tool-permission-text
Mar 9, 2026
Merged

fix(i18n): clarify tool permission title as 'Pre-approved Tools'#13327
EurFelux merged 1 commit intomainfrom
fix/tool-permission-text

Conversation

@EurFelux
Copy link
Copy Markdown
Collaborator

@EurFelux EurFelux commented Mar 9, 2026

What this PR does

Before this PR:
The agent.settings.toolsMcp.tools.title i18n key showed "Tools" (or equivalents), which implied the switches control tool availability (whether a tool can be used at all).

After this PR:
The title now reads "Pre-approved Tools" (and equivalents in all locales), clearly indicating the switches control pre-approval permissions — tools not in the whitelist are still usable but require per-use approval at runtime.

Fixes #13319

Why we need it and why it was done in this way

The code fallback text was already "Pre-approved Tools" but the i18n values were simplified to just "Tools", losing the important semantic meaning. This PR aligns all 11 locale files with the intended wording.

The following tradeoffs were made: None — this is a straightforward i18n text correction.

The following alternatives were considered: N/A

Breaking changes

None.

Special notes for your reviewer

  • The dead i18n keys under agent.settings.tools.* (which have zero code references) were left untouched — cleanup can be done separately.
  • Translations for de, el, es, fr, ja, pt, ro, ru were based on the existing agent.settings.tools.title values where correct, and newly translated where they were also wrong.

Checklist

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Documentation: N/A — no user-facing doc update needed
  • Self-review: I have reviewed my own code before requesting review from others

Release note

Fix misleading "Tools" section title in Agent Settings to "Pre-approved Tools" across all locales, clarifying that switches control pre-approval permissions, not tool availability.

…tics

The section title "Tools" was misleading — it implied the switches
control tool availability, when they actually control pre-approval
permissions. Updated all 11 locale files to say "Pre-approved Tools"
(and equivalents) to match the code fallback text.

Closes #13319

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: icarus <[email protected]>
@EurFelux EurFelux requested review from DeJeune and kangfenmao March 9, 2026 07:38
Copy link
Copy Markdown
Contributor

@cherry-ai-bot cherry-ai-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR cleanly clarifies the tools permission title to 'Pre-approved Tools' across locales, with no logic changes and low regression risk.

@EurFelux EurFelux merged commit 431de65 into main Mar 9, 2026
12 checks passed
@EurFelux EurFelux deleted the fix/tool-permission-text branch March 9, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Agent tools section title "Tools" is misleading — should indicate "Pre-approved" semantics

2 participants