revert: remove Feishu at-mention from issue notification card#13201
revert: remove Feishu at-mention from issue notification card#13201
Conversation
Change the at-mention ID from cli_a92d6e7ba3f85ced to ou_ad34e67a0c870cb54598add5797da51d to use open_id for user mentions. Co-Authored-By: Claude Opus 4.6 <[email protected]>
…9432e Co-Authored-By: Claude Opus 4.6 <[email protected]>
scripts/feishu-notify.ts
Outdated
| tag: 'div', | ||
| text: { | ||
| tag: 'lark_md', | ||
| content: `<at id=ou_07e5565fa3a77665648fd85edb09432e></at>` |
There was a problem hiding this comment.
Note
This issue/comment/review was translated by Claude.
What impact will exposing this ID have?
Original Content
这个id公开出来会有什么影响吗
There was a problem hiding this comment.
Note
This issue/comment/review was translated by Claude.
Shouldn't have any effect? The actual application still requires secret verification.
Original Content
应该没啥影响？实际应用还需要有一个secret校验
There was a problem hiding this comment.
Note
This issue/comment/review was translated by Claude.
The values received by each application are different, but that's not a problem.
Original Content
每个应用拿到的不通用，问题不大
There was a problem hiding this comment.
Note
This issue/comment/review was translated by Claude.
Additional suggestion: Avoid hardcoding Feishu mention IDs in the repository. Consider using environment variables or CLI parameters for configuration instead.
Original Content
补充建议：避免在仓库中硬编码 Feishu mention ID，建议改为环境变量或 CLI 参数可配置。
scripts/feishu-notify.ts
Outdated
| text: { | ||
| tag: 'lark_md', | ||
| content: `<at id=cli_a92d6e7ba3f85ced></at>` | ||
| content: `<at id=ou_07e5565fa3a77665648fd85edb09432e></at>` |
There was a problem hiding this comment.
Note
This issue/comment/review was translated by Claude.
This replaces the mention ID from one hardcoded value to another hardcoded value (app_id -> open_id), which still has poor maintainability. I suggest using environment variables or CLI parameters for injection instead (e.g., FEISHU_MENTION_OPEN_ID / --mention-open-id), and don't @ when empty, which is safer and more flexible across different environments and different on-call persons.
Original Content
这里把 mention ID 从一个硬编码值替换成另一个硬编码值（app_id -> open_id），可维护性仍然较差。建议改为通过环境变量或 CLI 参数注入（例如 FEISHU_MENTION_OPEN_ID / --mention-open-id），为空时不 @，这样在不同环境和不同值班人之间更安全也更灵活。
…fd85edb09432e" This reverts commit 9741112.
DeJeune
changed the title
3 participants
What this PR does
Before this PR:
Attempted to add Feishu @mention notifications in issue cards using
<at id=...></at>tags with various ID formats (app ID, open_id).After this PR:
Reverted all mention-related changes. The Feishu card content is restored to its original state without @mention tags.
Why we need it and why it was done in this way
Testing confirmed that while the
<at>tag with open_id displays correctly in the card, Feishu does not provide a message receive API for bots — so bot users cannot actually receive @mention notifications. The feature is not feasible with the current Feishu API capabilities.Breaking changes
None
Special notes for your reviewer
This PR reverts the mention feature added in #13199 and all subsequent test commits. Net diff against
mainshould only contain the revert of #13199.Checklist
Release note