Skip to content

feat: mention Feishu user in issue notification card#13199

Merged
DeJeune merged 1 commit intomainfrom
DeJeune/feishu-mention-user
Mar 4, 2026
Merged

feat: mention Feishu user in issue notification card#13199
DeJeune merged 1 commit intomainfrom
DeJeune/feishu-mention-user

Conversation

@DeJeune
Copy link
Copy Markdown
Collaborator

@DeJeune DeJeune commented Mar 4, 2026

What this PR does

Before this PR:
Feishu issue notification cards did not @mention any specific user, so notifications could be easily missed.

After this PR:
The issue notification card now includes an <at> element that @mentions the Feishu user cli_a92d6e7ba3f85ced in the card body, ensuring they receive a direct notification for every new GitHub issue.

Why we need it and why it was done in this way

The Feishu user needs to be actively notified when new GitHub issues are created. By embedding the <at id=cli_a92d6e7ba3f85ced></at> tag directly in the card's lark_md content, the user gets a native Feishu @mention notification without requiring changes to the workflow or CLI interface.

The following tradeoffs were made:

  • The Feishu user ID is hardcoded in the card template rather than passed as a CLI option. This is simpler and sufficient for the current use case.

The following alternatives were considered:

  • Adding a --mention CLI option: More flexible but unnecessary complexity for a single user.
  • Adding the @mention via the workflow prompt: Less reliable since it depends on Claude's output.

Breaking changes

None.

Special notes for your reviewer

The TypeScript diagnostics shown for feishu-notify.ts (missing process, Buffer, etc.) are pre-existing and unrelated to this change — the script runs via npx tsx and is outside the project's tsconfig scope.

Checklist

Release note

NONE

Add @mention for Feishu user (cli_a92d6e7ba3f85ced) in the issue
notification card body, so the user gets notified in Feishu when
a new GitHub issue is processed.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@DeJeune DeJeune requested a review from EurFelux March 4, 2026 07:54
@DeJeune DeJeune merged commit 1e44459 into main Mar 4, 2026
11 checks passed
@DeJeune DeJeune deleted the DeJeune/feishu-mention-user branch March 4, 2026 08:01
DeJeune added a commit that referenced this pull request Mar 4, 2026
DeJeune added a commit that referenced this pull request Mar 4, 2026
### What this PR does

Before this PR:
Attempted to add Feishu @mention notifications in issue cards using `<at
id=...></at>` tags with various ID formats (app ID, open_id).

After this PR:
Reverted all mention-related changes. The Feishu card content is
restored to its original state without @mention tags.

### Why we need it and why it was done in this way

Testing confirmed that while the `<at>` tag with open_id displays
correctly in the card, Feishu does not provide a message receive API for
bots — so bot users cannot actually receive @mention notifications. The
feature is not feasible with the current Feishu API capabilities.

### Breaking changes

None

### Special notes for your reviewer

This PR reverts the mention feature added in #13199 and all subsequent
test commits. Net diff against `main` should only contain the revert of
#13199.

### Checklist

- [x] PR: The PR description is expressive enough and will help future
contributors
- [x] Code: Write code that humans can understand and Keep it simple
- [x] Refactor: You have left the code cleaner than you found it (Boy
Scout Rule)
- [x] Upgrade: Impact of this change on upgrade flows was considered and
addressed if required
- [ ] Documentation: N/A - no user-facing change
- [x] Self-review: I have reviewed my own code before requesting review
from others

### Release note

```release-note
NONE
```

---------

Co-authored-by: Claude Opus 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants