Skip to content

fix: codemirror highlight crash#13196

Merged
DeJeune merged 1 commit intoCherryHQ:mainfrom
kovsu:fix-codemirror-version
Mar 4, 2026
Merged

fix: codemirror highlight crash#13196
DeJeune merged 1 commit intoCherryHQ:mainfrom
kovsu:fix-codemirror-version

Conversation

@kovsu
Copy link
Copy Markdown
Collaborator

@kovsu kovsu commented Mar 4, 2026

@uiw/[email protected] introduced @lezer/[email protected]as a transitive dependency, while @lezer/[email protected] was still locked to @lezer/[email protected].

// pnpm-lock.yaml
'@uiw/codemirror-extensions-langs':
        specifier: 4.25.7
        version: 4.25.7(...)(@lezer/[email protected])(@lezer/[email protected])(...)
        
        
'@lezer/[email protected]':
    dependencies:
      '@lezer/common': 1.5.0
Parser          (from extensions-langs, uses @lezer/[email protected])
    ↓ produces Tree/Node objects
    
Highlighter     (from @lezer/highlight, uses @lezer/[email protected])
    ↓ tries to process those nodes
    
Result: Node type mismatch → highlighting silently fails or throws
CleanShot 2026-03-04 at 14 12 26@2x

@DeJeune DeJeune requested a review from EurFelux March 4, 2026 06:28
@DeJeune DeJeune merged commit b1493d4 into CherryHQ:main Mar 4, 2026
11 checks passed
@kovsu kovsu deleted the fix-codemirror-version branch March 4, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EurFelux EurFelux EurFelux approved these changes

@GeorgeDong32 GeorgeDong32 GeorgeDong32 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kovsu @EurFelux @GeorgeDong32 @DeJeune