chore: Improve Claude translator workflow logic and clarity#13175
Merged
GeorgeDong32 merged 1 commit intomainfrom Mar 3, 2026
Merged
chore: Improve Claude translator workflow logic and clarity#13175GeorgeDong32 merged 1 commit intomainfrom
GeorgeDong32 merged 1 commit intomainfrom
Conversation
DeJeune
approved these changes
Mar 3, 2026
GeorgeDong32
approved these changes
Mar 3, 2026
Collaborator
GeorgeDong32
left a comment
There was a problem hiding this comment.
LGTM. The prompt improvements make the skip logic much clearer and will help reduce unnecessary API calls. Good cleanup on punctuation consistency as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The Claude translator workflow had ambiguous skip conditions. For example, it didn't explicitly state when to skip already-translated or already-English content, and the catch-all rule was vaguely worded as "doesn't need any processing."
After this PR:
The translator workflow now has clearer, more explicit logic:
Why we need it and why it was done in this way
We noticed that the translator workflow would sometimes unnecessarily re-translate content that was already in English. The root cause was ambiguous skip conditions in the prompt — the workflow lacked an explicit instruction to skip when the content is already English, causing Claude to "translate" English into English redundantly.
This PR makes all skip conditions explicit to prevent such unnecessary translations and reduce wasted API calls.
The following tradeoffs were made: N/A
The following alternatives were considered: N/A
Breaking changes
None.
Special notes for your reviewer
This is a prompt-level change only — no code logic is affected. The workflow behavior should be functionally equivalent but with clearer instructions for the Claude model.
Checklist
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note