Skip to content

chore: Improve Claude translator workflow logic and clarity#13175

Merged
GeorgeDong32 merged 1 commit intomainfrom
chore/improve-translator
Mar 3, 2026
Merged

chore: Improve Claude translator workflow logic and clarity#13175
GeorgeDong32 merged 1 commit intomainfrom
chore/improve-translator

Conversation

@EurFelux
Copy link
Copy Markdown
Collaborator

@EurFelux EurFelux commented Mar 3, 2026

What this PR does

Before this PR:
The Claude translator workflow had ambiguous skip conditions. For example, it didn't explicitly state when to skip already-translated or already-English content, and the catch-all rule was vaguely worded as "doesn't need any processing."

After this PR:
The translator workflow now has clearer, more explicit logic:

  • Explicitly skips when translated content already matches the original.
  • Explicitly skips when the content is already in English.
  • The catch-all rule now reads "doesn't match any of the above cases, skip the task."
  • Consistent punctuation (semicolons) across all rule items.

Why we need it and why it was done in this way

We noticed that the translator workflow would sometimes unnecessarily re-translate content that was already in English. The root cause was ambiguous skip conditions in the prompt — the workflow lacked an explicit instruction to skip when the content is already English, causing Claude to "translate" English into English redundantly.

This PR makes all skip conditions explicit to prevent such unnecessary translations and reduce wasted API calls.

The following tradeoffs were made: N/A

The following alternatives were considered: N/A

Breaking changes

None.

Special notes for your reviewer

This is a prompt-level change only — no code logic is affected. The workflow behavior should be functionally equivalent but with clearer instructions for the Claude model.

Checklist

Release note

NONE

@EurFelux EurFelux changed the title fix: Improve Claude translator workflow logic and clarity chore: Improve Claude translator workflow logic and clarity Mar 3, 2026
Copy link
Copy Markdown
Collaborator

@GeorgeDong32 GeorgeDong32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The prompt improvements make the skip logic much clearer and will help reduce unnecessary API calls. Good cleanup on punctuation consistency as well.

@GeorgeDong32 GeorgeDong32 merged commit 7f00841 into main Mar 3, 2026
23 checks passed
@GeorgeDong32 GeorgeDong32 deleted the chore/improve-translator branch March 3, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants