Skip to content

refactor: Improve plugin detail modal UI and fix size display#13090

Merged
kangfenmao merged 4 commits intomainfrom
refactor/plugin-detail-modal
Mar 5, 2026
Merged

refactor: Improve plugin detail modal UI and fix size display#13090
kangfenmao merged 4 commits intomainfrom
refactor/plugin-detail-modal

Conversation

@EurFelux
Copy link
Copy Markdown
Collaborator

@EurFelux EurFelux commented Feb 27, 2026

What this PR does

Before this PR:

  • Plugin size displayed as 0 in the plugin detail modal
  • Plugin detail modal had basic styling
image

After this PR:

  • Fixed plugin size displaying as 0 by using null for unknown sizes
  • Improved plugin detail modal UI with better layout and styling
image

Fixes #

Why we need it and why it was done in this way

The plugin detail modal was showing size as 0 because the size value was not being properly passed or was being treated as unknown. This PR fixes the issue by properly handling null values for unknown sizes and improves the overall UI styling.

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

Fixed plugin size displaying as 0 in the plugin detail modal. Improved plugin detail modal UI with better layout and styling.

@EurFelux EurFelux changed the title 改进样式,并修复了size在前端显示总是为0的问题 refactor: Improve plugin detail modal UI and fix size display Feb 27, 2026
Copy link
Copy Markdown
Collaborator

@DeJeune DeJeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EurFelux added a commit that referenced this pull request Feb 27, 2026
@DeJeune DeJeune added this to the v1.7.22 milestone Feb 28, 2026
@kangfenmao kangfenmao merged commit 0e29def into main Mar 5, 2026
9 checks passed
@kangfenmao kangfenmao deleted the refactor/plugin-detail-modal branch March 5, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants