chore: use node-version-file for CI workflows#13076
Merged
GeorgeDong32 merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
Update workflows to read Node version from .node-version file instead of hardcoding node-version: 22. Also bump Node version to 24.11.1 to match Electron runtime. Co-Authored-By: Claude Opus 4.6 <[email protected]>
DeJeune
approved these changes
Feb 26, 2026
GeorgeDong32
approved these changes
Feb 26, 2026
Collaborator
GeorgeDong32
left a comment
GeorgeDong32
left a comment
There was a problem hiding this comment.
LGTM! Using node-version-file is the recommended approach for managing Node.js versions in GitHub Actions. The change aligns CI with package.json requirements (Node 24.11.1) and improves maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
node-version: 22.node-versionand.nvmrcfiles were at version 22After this PR:
.node-versionfile usingnode-version-file: '.node-version'.node-versionand.nvmrcupdated to24.11.1to match Electron runtime versionFixes #
Why we need it and why it was done in this way
The project recently updated Node.js requirement to 24.11.1 in package.json, but the CI workflows were still hardcoded to use Node 22, causing warning. This change makes the CI workflows automatically use the Node version defined in
.node-versionfile, ensuring consistency between local development and CI environments.The following tradeoffs were made:
.node-versioninstead of reading frompackage.jsondirectly - simpler and more compatible with GitHub ActionsThe following alternatives were considered:
Links to places where the discussion took place:
Breaking changes
If this PR introduces breaking changes, please describe the changes and the impact on users.
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note