fix: defer provider name trimming to submission time#12903
Merged
kangfenmao merged 1 commit intomainfrom Feb 13, 2026
Merged
Conversation
Improve UX by allowing users to type spaces while editing provider names. The name is now trimmed only when submitting, not on every keystroke.
DeJeune
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
After this PR:
onOkandonClose)Fixes #
Why we need it and why it was done in this way
This improves the user experience by allowing natural typing behavior. Users can now type spaces between words (e.g., "My Provider") without the spaces being immediately stripped.
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
N/A
Breaking changes
None. This is a pure UX improvement with no API or data model changes.
Special notes for your reviewer
onOk(submit) andonClosepaths trim the namebuttonDisabledlogic now correctly checks if the trimmed name is emptyChecklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note