-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add CC2 support #11
Conversation
Summary: The chipset is no longer a one-to-one mapping with the vendor ids. I updated @Raymo111's commit to move the chipset away from the product id decorator and instead something that's assigned within each class' Sorry for bikeshedding over such a simple change; I sometimes* obsess over semantics :) |
Note to @Raymo111, don't merge this. If you approve, just approve and I'll rebase to pop the older commit, add you as a co-author on mine and then merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can't we just squash merge |
Yeah, the reason I said that initially was because of this line: charachorder.py/charachorder/device.py Line 716 in c32a24d
This wasn't there before; I thought I had missed it in some other class so I wanted that to be a separate commit. I realised now that it was missing in the new CC2 class, which obv is fine to be in the same commit if squashed. |
No description provided.