Repository navigation
Commit 7ce4746
authored
[web] Accept the capped letter spacing line shift in kitchensink (flutter#196148)
The SkParagraph kitchensink test in canvaskit_api_test.dart pins
LineMetrics.left to 2.5. Its line starts with letterSpacing 5 and ends
with an unspaced "!", and Skia shifted the whole line right by half the
first spacing, so the "!" ended 2.5 px past the line width. A Skia
change
for flutter#184815 caps the shift by
the half spacing of the visually last cluster, which is 0 here, and it
broke the Skia roll (flutter#196144).
Accept both 2.5 and 0 so the Skia change can reland. A follow-up after
the roll expects 0 only.
Assisted-by: Claude Opus 5.5 (Medium)1 parent 9ac9b06 commit 7ce4746
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1632 | 1632 | | |
1633 | 1633 | | |
1634 | 1634 | | |
1635 | | - | |
| 1635 | + | |
| 1636 | + | |
| 1637 | + | |
| 1638 | + | |
| 1639 | + | |
| 1640 | + | |
| 1641 | + | |
1636 | 1642 | | |
1637 | 1643 | | |
1638 | 1644 | | |
| |||
0 commit comments