Repository navigation
Commit 7c68585
committed
fix(shell): throttle streaming output metadata updates to cut CPU
The shell tool called ctx.metadata({ output: last }) on every stdout
chunk. Each call flows through updateToolCall -> session.updatePart ->
a durable message.part.updated event, which commits a synchronous
SQLite IMMEDIATE transaction (schema encode + full-snapshot row in the
event table + projector write) plus GlobalBus emits and per-SSE-client
serialization. A long-running command emitting output over time therefore
fired one synchronous SQLite transaction per chunk on the server event
loop, pinning CPU at 100% and bloating the event table.
Coalesce the intermediate preview updates to at most one every
METADATA_THROTTLE_MS (100ms) while streaming, and flush the final preview
once when the command completes. Correctness is preserved: the rolling
`last` preview is still updated on every chunk, the tool's return value
still carries the complete final metadata (persisted durably by
completeToolCall), and the final flush publishes the complete preview
promptly. Only the frequency of intermediate durable writes changes;
what the user ultimately sees does not.
Add a test that paces stdout across many chunks (output spread over time,
since instantaneous output is coalesced by the OS pipe) and asserts the
number of metadata updates is far below the number of chunks while the
final update still carries the complete output.
Fixes anomalyco#31831
Related: anomalyco#33399, anomalyco#333561 parent 0a601cf commit 7c68585
2 files changed
Lines changed: 100 additions & 26 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
28 | 33 | | |
29 | 34 | | |
30 | 35 | | |
| |||
446 | 451 | | |
447 | 452 | | |
448 | 453 | | |
| 454 | + | |
449 | 455 | | |
450 | 456 | | |
451 | 457 | | |
| |||
499 | 505 | | |
500 | 506 | | |
501 | 507 | | |
502 | | - | |
503 | | - | |
504 | | - | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | | - | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
523 | 524 | | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
524 | 533 | | |
525 | | - | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
530 | 542 | | |
531 | 543 | | |
532 | 544 | | |
| |||
558 | 570 | | |
559 | 571 | | |
560 | 572 | | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
561 | 582 | | |
562 | 583 | | |
563 | 584 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1131 | 1131 | | |
1132 | 1132 | | |
1133 | 1133 | | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
1134 | 1187 | | |
1135 | 1188 | | |
1136 | 1189 | | |
| |||
0 commit comments