This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Removing TODOs and simplifying deploymenttable.ts#527
Merged
samiyaakhtar merged 12 commits intoCatalystCode:masterfrom Apr 9, 2020
Merged
Removing TODOs and simplifying deploymenttable.ts#527samiyaakhtar merged 12 commits intoCatalystCode:masterfrom
samiyaakhtar merged 12 commits intoCatalystCode:masterfrom
Conversation
evanlouie
approved these changes
Apr 8, 2020
andrebriggs
suggested changes
Apr 8, 2020
Collaborator
andrebriggs
left a comment
andrebriggs
left a comment
There was a problem hiding this comment.
Pending sync to discuss this area
samiyaakhtar
changed the title
samiyaakhtar
requested review from
NathanielRose,
bnookala,
edaena,
mtarng,
sarath-p and
yradsmikham
yradsmikham
approved these changes
Apr 8, 2020
mtarng
reviewed
Apr 8, 2020
Collaborator
mtarng
left a comment
mtarng
left a comment
There was a problem hiding this comment.
Looks like we can probably also remove /* eslint-disable @typescript-eslint/no-use-before-define */ from deploymenttable.ts at this time.
mtarng
approved these changes
Apr 8, 2020
dennisseah
approved these changes
Apr 8, 2020
andrebriggs
approved these changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes microsoft/bedrock#1301