This repository was archived by the owner on Apr 13, 2020. It is now read-only.
resolve bug with gitPull between repo tags and repo branches#521
Merged
yradsmikham merged 2 commits intomasterfrom Apr 7, 2020
Merged
resolve bug with gitPull between repo tags and repo branches#521yradsmikham merged 2 commits intomasterfrom
yradsmikham merged 2 commits intomasterfrom
Conversation
yradsmikham
requested review from
NathanielRose,
andrebriggs,
dennisseah and
jmspring
dennisseah
reviewed
Apr 7, 2020
| ); | ||
| await simpleGit(sourcePath).pull(); | ||
| } catch (err) { | ||
| logger.info( |
Collaborator
There was a problem hiding this comment.
question: what is the assumption here. Is it that exec or simpleGit functions fail and we ignore the error?
Collaborator
Author
There was a problem hiding this comment.
The logic is that if the exec command fails, then the passed in version argument is a git tag as opposed to a git branch, in which case don't perform git pull because it will cause the error that is seen now.
samiyaakhtar
approved these changes
Apr 7, 2020
dennisseah
approved these changes
Apr 7, 2020
NathanielRose
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close microsoft/bedrock#1303.