This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[BUG FIX] add proper error message when PAT is incorrect.#515
Merged
dennisseah merged 9 commits intomasterfrom Apr 7, 2020
Merged
[BUG FIX] add proper error message when PAT is incorrect.#515dennisseah merged 9 commits intomasterfrom
dennisseah merged 9 commits intomasterfrom
Conversation
mtarng
reviewed
Apr 6, 2020
src/lib/i18n.json
Outdated
| "setup-cmd-prompt-err-no-subscriptions": "No subscriptions found.", | ||
| "setup-cmd-prompt-err-subscription-missing": "Subscription Identifier was missing.", | ||
| "setup-cmd-prompt-err-input-file-missing": "{0} did not exist or not accessible. Make sure that it is accessible.", | ||
| "setup-cmd-core-api-err": "Could not get Core API client. Check the Azure credential", |
Collaborator
There was a problem hiding this comment.
Core API is also for Azure DevOps. Let's be specific so we don't confuse the user between Azure and Azure DevOps here.
Collaborator
Author
There was a problem hiding this comment.
can you suggest a good message? thanks
Collaborator
There was a problem hiding this comment.
The same message as the other errors:
Something like
Could not initialize Core API client. Check the Azure DevOps credentials.
This is just being explicit about Azure vs Azure DevOps
Collaborator
Author
There was a problem hiding this comment.
actually, this one is for Azure and not Azure DevOps. the other 2 are for Azure DevOps. We are using PAT to authenticate for this one and using Service Principal for the other 2.
yradsmikham
approved these changes
Apr 6, 2020
andrebriggs
approved these changes
Apr 7, 2020
Collaborator
Author
|
integration test results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: microsoft/bedrock#1281
this is what we get when PAT is incorrect