[FEATURE] have error code for deployment get command#511
Conversation
dennisseah
requested review from
andrebriggs,
edaena,
evanlouie and
samiyaakhtar
|
Seeing a regression when i run against this branch: |
i will test again. does this happens only for -wide? |
|
@dennisseah yes |
it is also happening for master branch because here https://github.com/CatalystCode/spk/blob/master/src/commands/deployment/get.ts#L244, we have .then and do not have .catch. I will try to fix this. I guess we print warning if we cannot fetch PR, please confirm |
|
@dennisseah interesting, didn't see it happen on master for me but maybe i need to pull again. |
|
@dennisseah i just pulled the latest and it's working on master. Maybe we need to have promise and resolve? |
edaena
left a comment
edaena
left a comment
There was a problem hiding this comment.
Looks good. Just verify the functionality by running the integration tests before merging.
samiyaakhtar
left a comment
samiyaakhtar
left a comment
There was a problem hiding this comment.
Works with -o wide now. Thanks @dennisseah
3 participants
ran integration test successfully
closes microsoft/bedrock#1316