This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FEATURE] inheritence information in operational doc#510
Merged
dennisseah merged 6 commits intomasterfrom Apr 6, 2020
Merged
Conversation
dennisseah
requested review from
andrebriggs,
bnookala,
edaena,
evanlouie and
samiyaakhtar
samiyaakhtar
reviewed
Apr 6, 2020
| (opts.repoName = | ||
| getRepositoryName(repoUrl) || getRepositoryName(gitOriginUrl)), | ||
| (opts.repoUrl = opts.repoUrl || getRepositoryUrl(gitOriginUrl)); | ||
| opts.yamlFileBranch = opts.yamlFileBranch || "master"; |
Collaborator
There was a problem hiding this comment.
is || "master" needed?
Collaborator
Author
There was a problem hiding this comment.
for defensive programming purposes.
samiyaakhtar
approved these changes
Apr 6, 2020
yradsmikham
approved these changes
Apr 6, 2020
Collaborator
Author
|
ran validations.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes microsoft/bedrock#1315
added inherit properties to command decorator json file and use
populateInheritValueFromConfigandvalidateForRequiredValuesfunctions to inherit values from config.xml and check that all mandatory options have values respectively. hence removing code of performing the above tasks inpipeline.tsfilealso have the
validateForRequiredValuesinvalidator.tsto throw error from error builder.ran
validation.sh- passed