Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

[FEATURE] simplify inheriting opt values from config.yaml for svc pipeline cmd#508

Merged
dennisseah merged 5 commits intomasterfrom
issue1314
Apr 6, 2020
Merged

[FEATURE] simplify inheriting opt values from config.yaml for svc pipeline cmd#508
dennisseah merged 5 commits intomasterfrom
issue1314

Conversation

@dennisseah
Copy link
Collaborator

@dennisseah dennisseah commented Apr 3, 2020

closes microsoft/bedrock#1314

before this, we do not check if personal access token, org name and project name are provided or can be inherited from config.yaml.

added inherit properties to command decorator json file and use
populateInheritValueFromConfig and validateForRequiredValues functions to inherit values from config.xml and check that all mandatory options have values respectively. hence removing code of performing the above tasks in pipeline.ts file

@dennisseah dennisseah changed the title [HOUSEKEEPING] simplify inheriting opt values from config.yaml for svc pipeline cmd [FEATURE] simplify inheriting opt values from config.yaml for svc pipeline cmd Apr 4, 2020
@dennisseah
Copy link
Collaborator Author

dennisseah commented Apr 6, 2020 

pipeline: fabrikam-hld-to-fabrikam-manifests-408:
pipeline_status this iteration --> "completed"
Successful build for pipeline: fabrikam-hld-to-fabrikam-manifests-408!
info:    Generating config.yaml from yaml file input.
info:    config.yaml was generated and located at /Users/veseah/.spk/config.yaml.
info:    Successfully initialized the spk tool!
Start Time           Service      Deployment   Commit  Src to ACR Image Tag                                             Result ACR to HLD Env    Hld Commit Result HLD to Manifest Result
4/6/2020, 3:07:44 PM fabrikam2019 1e2e132b6505 7b27451 657        fabrikam2019-fabrikam.acme.frontend:master-20200406.1 ✓      657        MASTER bab4568    ✓      658             ✓     
1 deployment(s) were returned by spk deployment get
Verified that srcPipeline:657 acrPipelineId:657 hldPipelineId:658 pullrequest:"337" are all linked together correctly.
Successfully reached the end of spk deployment get tests.

@dennisseah dennisseah merged commit bffdf30 into master Apr 6, 2020
@dennisseah dennisseah deleted the issue1314 branch April 6, 2020 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@evanlouie evanlouie Awaiting requested review from evanlouie

@andrebriggs andrebriggs Awaiting requested review from andrebriggs

@edaena edaena Awaiting requested review from edaena

2 more reviewers

@bnookala bnookala bnookala approved these changes

@yradsmikham yradsmikham yradsmikham approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify inheritance of option values for service install-build-pipeline command

3 participants

@dennisseah @bnookala @yradsmikham