Conversation
src/commands/project/pipeline.ts
Outdated
| @@ -143,7 +143,7 @@ export const fetchValidateValues = ( | |||
| orgName: opts.orgName || "", | |||
There was a problem hiding this comment.
This whole logic section is kinda confusing. Why are we still loading from opts from here. Shouldn't all of these be loaded from the values object instead?
This was introduced in: https://github.com/CatalystCode/spk/pull/479/files
@edaena @dennisseah does this make sense for us to fix this all here? Does similar logic for other ConfigValues interfaces exist now too in other commands?
There was a problem hiding this comment.
@mtarng do you know other places that this problem too?
There was a problem hiding this comment.
I'm not sure, which is why I asked the question @dennisseah . Have we refactored any other commands to move arguments from CommandOptions to ConfigValues?
Repository name is not part of the supported "opts"