This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FEATURE] have error code and chaining for deployment validate cmd#490
Merged
dennisseah merged 5 commits intomasterfrom Apr 1, 2020
Merged
[FEATURE] have error code and chaining for deployment validate cmd#490dennisseah merged 5 commits intomasterfrom
dennisseah merged 5 commits intomasterfrom
Conversation
dennisseah
requested review from
anderm,
edaena,
evanlouie,
mtarng and
samiyaakhtar
edaena
approved these changes
Apr 1, 2020
Collaborator
|
Would be nice to run the integration test for this logic (for changes in |
samiyaakhtar
approved these changes
Apr 1, 2020
Collaborator
Author
which integration test has this command, I did a grep and cannot find it. thanks |
Collaborator
|
The integration tests create pipelines which use this command, so it's not directly called from the integration test files. I think you can merge and if something breaks, we will see. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes microsoft/bedrock#1291
also fix typos
rename validation.md => validate.md and validation.decorator.json => validate.decorator.json because they are named incorrectly