This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FEATURE] Add Specific error code for infra generate command#471
Merged
dennisseah merged 7 commits intomasterfrom Mar 30, 2020
Merged
[FEATURE] Add Specific error code for infra generate command#471dennisseah merged 7 commits intomasterfrom
dennisseah merged 7 commits intomasterfrom
Conversation
Collaborator
Author
|
@yradsmikham, @NathanielRose there are two |
yradsmikham
reviewed
Mar 30, 2020
yradsmikham
reviewed
Mar 30, 2020
src/commands/infra/generate.ts
Outdated
| checkTfvars(parentDirectory, BACKEND_TFVARS); | ||
| writeTfvarsFile(backendTfvarsObject, parentDirectory, BACKEND_TFVARS); | ||
| } else { | ||
| // TOFIX: are these warnings? if yes, please write some comments. |
Collaborator
There was a problem hiding this comment.
This is also another valid warning.
Collaborator
There was a problem hiding this comment.
Not all templates will require a remote backend (i.e Bedrock's azure-simple). Keep in mind, that if a remote backend is not configured for a template, it will be impossible to be able to use spk infra in a pipeline, but this can still work locally.
yradsmikham
approved these changes
Mar 30, 2020
Collaborator
Author
|
@yradsmikham and @NathanielRose , thank so much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes microsoft/bedrock#1277
getting messages like this