Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

[FEATURE] add exception chain to hld add variable group command#470

Merged
dennisseah merged 3 commits intomasterfrom
errorHandlingHLDavg
Mar 30, 2020
Merged

[FEATURE] add exception chain to hld add variable group command#470
dennisseah merged 3 commits intomasterfrom
errorHandlingHLDavg

Conversation

@dennisseah
Copy link
Collaborator

@dennisseah dennisseah commented Mar 28, 2020 •
edited
Loading

closes microsoft/bedrock#1265

also fixed eslint-disable error
also added code to make sure that empty string with spaces are not allowed as variable group name

$ ts-node src/index.ts hld avg " "
error:   
code: 1000
message: hld-append-var-group-cmd-failed: HLD Append Variable Group Command was not successfully executed.
  code: 1001
  message: hld-append-var-group-name-missing: Variable group name was not provided. Provide variable group.

$ ts-node src/index.ts hld avg "a"
error:   
code: 1000
message: hld-append-var-group-cmd-failed: HLD Append Variable Group Command was not successfully executed.
  code: 1011
  message: fileutils-append-variable-group-to-pipeline-yaml: Could not append variable group name to manifest-generation.yaml file in HLD repo. Check this is file exist and if it is YAML format.
  details: Unable to load file '/Users/veseah/git/spk/manifest-generation.yaml'

andrebriggs
andrebriggs approved these changes Mar 30, 2020
View reviewed changes
Copy link
Collaborator

@andrebriggs andrebriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to seeing this in the rest of the codebase

@dennisseah dennisseah merged commit 5948d80 into master Mar 30, 2020
@dennisseah dennisseah deleted the errorHandlingHLDavg branch March 30, 2020 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@edaena edaena Awaiting requested review from edaena

@evanlouie evanlouie Awaiting requested review from evanlouie

2 more reviewers

@andrebriggs andrebriggs andrebriggs approved these changes

@mtarng mtarng mtarng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Specific error code for hld add variable group command

3 participants

@dennisseah @andrebriggs @mtarng