This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FEATURE] Completing spk setup command#464
Merged
dennisseah merged 23 commits intomasterfrom Mar 31, 2020
Merged
Conversation
dennisseah
requested review from
NathanielRose,
andrebriggs,
evanlouie and
mtarng
andrebriggs
approved these changes
Mar 30, 2020
Collaborator
andrebriggs
left a comment
andrebriggs
left a comment
There was a problem hiding this comment.
I tried it out and it works. As noted there is an issue when someone types in an invalid PAT. We can address separately. I created microsoft/bedrock#1281 to track
samiyaakhtar
approved these changes
Mar 31, 2020
| value: rc.storageAccountName | ||
| }, | ||
| INTROSPECTION_PARTITION_KEY: { | ||
| value: STORAGE_PARTITION_KEY |
Collaborator
There was a problem hiding this comment.
partition key is not being allowed to customize from setup command, if I understand correctly?
Collaborator
Author
There was a problem hiding this comment.
correct, it is hardcode. the command is target to get things working with the least question asked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes microsoft/bedrock#1211