Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

[HOUSEKEEPING] remove eslint-disable for hld reconicle command#455

Merged
andrebriggs merged 6 commits intomasterfrom
eslintFixForHLDCommand
Mar 27, 2020
Merged

[HOUSEKEEPING] remove eslint-disable for hld reconicle command#455
andrebriggs merged 6 commits intomasterfrom
eslintFixForHLDCommand

Conversation

@dennisseah
Copy link
Collaborator

@dennisseah dennisseah commented Mar 26, 2020 •
edited
Loading

mainly moving functions around to satisfy no-use-before-define rule
no changes in logics in this file

related to microsoft/bedrock#1157

andrebriggs
andrebriggs approved these changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@andrebriggs andrebriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticing how long reconcile.ts is 😅

bnookala
bnookala reviewed Mar 27, 2020
View reviewed changes
Copy link
Member

@bnookala bnookala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennisseah In the future, I would like for us to track this sort of housekeeping work on the sprint board - please make sure you are linking an issue/opening an issue so that we know it is happening.

bnookala
bnookala suggested changes Mar 27, 2020
View reviewed changes
Copy link
Member

@bnookala bnookala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennisseah Please add an issue to github, and add it to the sprint, as that's our process.

@andrebriggs andrebriggs merged commit bcdc1d3 into master Mar 27, 2020
@dennisseah
Copy link
Collaborator Author

dennisseah commented Mar 27, 2020

@dennisseah In the future, I would like for us to track this sort of housekeeping work on the sprint board - please make sure you are linking an issue/opening an issue so that we know it is happening.

sorry I forgot to link to an issue. I checked with Evan about removing the eslint-disabled when I have time. And he gave the green light. We have a lot of these after we switch from tslint to eslint

@dennisseah dennisseah deleted the eslintFixForHLDCommand branch March 27, 2020 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@edaena edaena Awaiting requested review from edaena

@mtarng mtarng Awaiting requested review from mtarng

3 more reviewers

@bnookala bnookala bnookala requested changes

@evanlouie evanlouie evanlouie approved these changes

@andrebriggs andrebriggs andrebriggs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dennisseah @bnookala @evanlouie @andrebriggs